-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth Provider: Update Nhost to V2 #4770
Conversation
Thanks @nunopato! We were having some trouble earlier with our CI yarn caching, so I gave it a reboot and think it's working now. Do we need to include instructions for existing projects to upgrade to these changes, e.g. https://github.com/redwoodjs/redwood/pull/4770/files#diff-0d0be1da1708452d96c61864423d49a276ec2b1dd9ff4be7cdbc1d62e8f50a38 Not sure if there's much use at this time. @dthyresson I'll let you determine if there are related doc updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nunopato. LGTM and we can then update the playground which I see you have done.
I am not merging, thought, since the title of this PR still says "[wip]".
I will update branch to have CI run again.
But, otherwise approved!
@nunopato please do let me know if this is GTG and I'll get it merged. Additionally, could you please:
Thanks! |
@thedavidprice PR is good to go.
Thank you @thedavidprice @dthyresson |
@nunopato Thank you! re: "The change would be to use the new SDK." Could you just comment here as to how someone would do that? From the diff, it looks like it's a simple import swap, correct? |
Yes, one would go from: import { createClient } from 'nhost-js-sdk'
const nhostClient = createClient({
baseUrl: 'url'
}) to import { NhostClient } from '@nhost/nhost-js'
const nhostClient = new NhostClient({
backendUrl: 'url'
}) |
Perfect. That’s all I need. Thank you! |
cc @dthyresson