Add flightcontrol deploy command #4788
Conversation
|
✅ Deploy Preview for redwoodjs-docs canceled. 🔨 Explore the source changes: bcd2a71 🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/62357d761e9e28000958bf99 |
|
Hello! Welcome and thanks for the PR! We've been big fans of @flybayer since we both started our frameworks around the same time. We're rooting for him and the team with Flightcontrol!
Whoops! Turns out |
|
@jtoar FYI re:
^^ I've noticed this isn't working for me locally as well. My guess is that it has something to do with recent move to Yarn 3 |
|
@beerose This is amazing! Excited to help you get this into Redwood. Local Dev What you can use instead is the
Also, here are the two main Contributing docs for ongoing reference: Deploy Target CI Repo That's the best way I can understand how everything works in order to review this PR and make sure all the pieces are connected! |
| if (serve) { | ||
| console.log('\nStarting api...') | ||
| await apiServerHandler({ | ||
| port: getConfig().api?.port || 8911, |
There was a problem hiding this comment.
I updated this because it was broken as is. Assuming you'll be port forwarding. Otherwise, I recommend updating in redwood.toml or just hardcoding here.
| // We need to set the apiUrl evn var for local dev | ||
| const addToDotEnvDefaultTask = () => { |
There was a problem hiding this comment.
Because the apiUrl was changed to use an env var, we need to make sure there's a value for local dev
| buildCommand: 'yarn rw deploy flightcontrol api', | ||
| startCommand: 'yarn rw deploy flightcontrol api --serve', |
There was a problem hiding this comment.
FYI updated these commands
| name: 'Redwood Web', | ||
| type: 'static', | ||
| singlePageApp: true, | ||
| buildCommand: 'yarn rw deploy flightcontrol web', |
There was a problem hiding this comment.
@beerose @flybayer Thanks again for getting this going! I've fixed some issues and made some config and command changed -- do review my changes, please, to confirm they'll all work with Flighcontrol.
So we can move forward, I'm going to merge this and use the corresponding published canary version over here: https://github.com/redwoodjs/deploy-target-ci
Things aren't quite working, so we'll keep at it!
This PR adds
rw setup deploy flightcontrolandrw deploy flightcontrolcommands.Link to the docs PR: #4788
Had some problems with testing the
rw deploycommand. I have a minimal redwood project, and runningyarn dev deploy flightcontrol web --cwd <path to my project>was resulting inCould not find a "redwood.toml" file, are you sure you're in a Redwood project?error. The file was there and it looked like the command was run in the correct directory. Any pointers would be appreciated 🙏