Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs): Minor Docusaurus setup updates #6381

Merged
merged 6 commits into from
Mar 6, 2023
Merged

(docs): Minor Docusaurus setup updates #6381

merged 6 commits into from
Mar 6, 2023

Conversation

dthyresson
Copy link
Contributor

When setting up Docusaurus and the GraphQL API document generator, I notice a few steps that needed clarification:

  • where to install Docusuarus
  • how to setup workspace
  • minor configuration adjustments

@dthyresson dthyresson added the release:docs This PR only updates docs label Sep 12, 2022
@dthyresson
Copy link
Contributor Author

@pantheredeye Is there any chance you can review the docs to setup Docusaurus -- and actually follow them to try it out on a project? I've done it a few times, but could use a second set of eyes to see if I missed anything. Would be a big help to get this issue closed out.

@dthyresson dthyresson marked this pull request as ready for review January 4, 2023 15:56
@dthyresson dthyresson changed the title DRAFT- (docs): Minor Docusaurus setup updates (docs): Minor Docusaurus setup updates Jan 4, 2023
pantheredeye
pantheredeye reviewed Jan 6, 2023
View reviewed changes
docs/docs/graphql.md Outdated Show resolved Hide resolved
pantheredeye
pantheredeye reviewed Jan 6, 2023
View reviewed changes
docs/docs/graphql.md Outdated Show resolved Hide resolved
pantheredeye
pantheredeye reviewed Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@pantheredeye pantheredeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DT, I would try to refactor some of this for you, but I cannot find the commit for some reason - I DM'd you about this.

@dthyresson
Copy link
Contributor Author

DT, I would try to refactor some of this for you, but I cannot find the commit for some reason - I DM'd you about this.

@pantheredeye Want to chat next week and see how to make changes?

@dthyresson
Copy link
Contributor Author

@pantheredeye Could you just "make suggestions" via the line comment form and then I can approve and it will auto merge? Thanks!

image

dthyresson
dthyresson commented Mar 6, 2023
View reviewed changes
Copy link
Contributor Author

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made updates from @pantheredeye 's review.

@dthyresson dthyresson merged commit 1eadf7c into redwoodjs:main Mar 6, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 6, 2023
jtoar pushed a commit that referenced this pull request Mar 8, 2023
@dthyresson @jtoar
(docs): Minor Docusaurus setup updates (#6381)
8340b0a 
* Minor Docusaurus setup updates

* Updates from Barret's review
@jtoar jtoar modified the milestones: next-release, v4.3.0 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pantheredeye pantheredeye pantheredeye left review comments

Assignees

@dthyresson dthyresson

@pantheredeye pantheredeye

Labels
release:docs This PR only updates docs
Projects
Main
Status: Done
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dthyresson @pantheredeye @jtoar