Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django integration #24

Open
Fel-o opened this issue Aug 26, 2019 · 1 comment
Open

Django integration #24

Fel-o opened this issue Aug 26, 2019 · 1 comment

Comments

@Fel-o
Copy link
Contributor

Fel-o commented Aug 26, 2019

How do you feel about permission classes which are not static like AllowAuthenticated or AllowSuperuser but which need to be instantiated.
I can imagine some scenarios where the option to only customize permission classes with class variables is not enough.
In my project I had some problems integrating this module with djangos integrated permissions feature. So I wrote a permission class like: AllowDjangoPermission("app_name.create_model"). Or something like AllowObjectOwner(related_object_path).
Is this a feature you would be interested in? I could create a new PullRequest after the feature to combine classes with operators is merged.

@redzej
Copy link
Owner

redzej commented Aug 28, 2019

This package was prepared for couple side projects, where all possible scenarios were not explored. Any extension that expands permissions and is useful for more people will be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants