Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Do we really need a custom webpack config? #22

Open
sirgalleto opened this issue May 14, 2020 · 0 comments
Open

[Question] Do we really need a custom webpack config? #22

sirgalleto opened this issue May 14, 2020 · 0 comments

Comments

@sirgalleto
Copy link

Hello guys, I was reviewing this project and a single question arrived to me: Do we really need to use a new webpack configuration?

I'm probably missing some context on the migration to ESmodules, but as far as I understand the further changes are:

  1. Point the import cesium to Cesium/Source. That's working from my side with cra.
  2. Import the widgets.css: If you import it from anywhere in your app is going to be bundled, you just need to do import 'cesium/Build/Cesium/Widgets/widgets.css'
  3. Copy the Cesium assets:

Instead of using webpack for copying Workers, ThirdParty, Assets, Widgets, you can just add a pre-script and copy them with a single command to your /public folder. And add that folder to your .gitignore.

I know this point is not the cleanest, but in a real project are you willing to maintain craco + craco-cesium for a single library?

  1. I know there is an issue with the dependency warnings, but makes more sense to push Cesium to perform any improvement.

Thanks for the time doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant