Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERGE_COMMIT_TEMPLATE does not work in Firefox #401

Open
maxbrunet opened this issue Feb 15, 2021 · 0 comments
Open

MERGE_COMMIT_TEMPLATE does not work in Firefox #401

maxbrunet opened this issue Feb 15, 2021 · 0 comments

Comments

@maxbrunet
Copy link
Contributor

The merge commit template insertion is skipped on an error, Refined Bibucket wrongly logs that it is related to permissions:

[refined-bitbucket] User doesn't have permissions to merge this pull request. Skipping "mergeCommitMessage" feature.

If I output the error in the catch, I get:

TypeError: 'setTimeout' called on an object that does not implement interface Window.

This seems to be thrown by the call to findAllByText() here:

const mergeSpans = await findAllByText(
document.body,
'Merge',
{},
{
timeout: 9000,
}
)

I have tried to upgrade @testing-library/dom to the latest version (v7.29.4), the error is not thrown anymore, but the call seems to never return.

I have also tested with Chrome where it works as expected.

It does not work in the old experience for both browsers, but I have not looked into it as it will be dropped by Bitbucket on Feb 15.

Versions

Firefox 85.0.2
Refined Bitubcket 3.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant