Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting loses background highlighting of changed parts #407

Open
mnn opened this issue Apr 7, 2021 · 4 comments
Open

Syntax highlighting loses background highlighting of changed parts #407

mnn opened this issue Apr 7, 2021 · 4 comments

Comments

@mnn
Copy link

mnn commented Apr 7, 2021

Without syntax highlighting:

2021-04-07_08-48

With syntax highlighting:

2021-04-07_08-49

It's a bit annoying. I am forced to frequently enable/disable the addon (usually per PR - for new code it's good to have syntax highlighting on, for changes it's better to see which parts were changed). It may not be that apparent from the simple example, but when you have a line of 120 characters and only one character changes, it takes longer to figure out what has changed with syntax highlighting on (so background diff is missing; if it's only few instances in PR then it's easy, but when you have changes in e.g. linter/formatting rules you get tons of such small changes).

@pastelsky
Copy link
Contributor

This should fix it —
#410

@dereknheiley
Copy link

@pastelsky looks like the changes had to be disabled by a patch update, any ETA to re-enable? looks like it might have been an edge case or two that needed to be handled?

@mnn
Copy link
Author

mnn commented Jul 20, 2022

Unfortunately the problem is still present. These are fresh screenshots:

2022-07-20_10-36

2022-07-20_10-37

Extension version: 3.26.1 (current on Chrome store)
Browser: Chromium 103.0.5060.114 (Official Build) Arch Linux (64-bit)

@DBX12
Copy link

DBX12 commented Aug 4, 2022

Can confirm what @mnn says for Extension version 3.26.1 on Firefox 91.12.0esr (64-bit) on debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants