You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The extension is great, and the Merge Commit Template feature is awesome, but there is an issue I found.
The approvedByList placeholder returns a message in the format "Approved By: Ronald Rey " (as stated in the docs).
This is invalid for commit footer according Conventional Commits and git trailer format.
Conventional Commits:
A footer’s token MUST use - in place of whitespace characters, e.g., Acked-by (this helps differentiate the footer section from a multi-paragraph body). An exception is made for BREAKING CHANGE, which MAY also be used as a token.
git-interpret-trailers:
When reading trailers, there can be no whitespace before or inside the token, but any number of regular space and tab characters are allowed between the token and the separator.
The default behavior in BitBucket is to use "Approved-By: Ronald Rey", which follows the rules above.
The text was updated successfully, but these errors were encountered:
The extension is great, and the Merge Commit Template feature is awesome, but there is an issue I found.
The
approvedByList
placeholder returns a message in the format "Approved By: Ronald Rey " (as stated in the docs).This is invalid for commit footer according Conventional Commits and git trailer format.
Conventional Commits:
git-interpret-trailers
:The default behavior in BitBucket is to use "Approved-By: Ronald Rey", which follows the rules above.
The text was updated successfully, but these errors were encountered: