Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commit template - approvedByList invalid for footer #454

Open
kpau opened this issue Jun 28, 2023 · 0 comments
Open

Merge commit template - approvedByList invalid for footer #454

kpau opened this issue Jun 28, 2023 · 0 comments

Comments

@kpau
Copy link

kpau commented Jun 28, 2023

The extension is great, and the Merge Commit Template feature is awesome, but there is an issue I found.
The approvedByList placeholder returns a message in the format "Approved By: Ronald Rey " (as stated in the docs).
This is invalid for commit footer according Conventional Commits and git trailer format.

Conventional Commits:

  1. A footer’s token MUST use - in place of whitespace characters, e.g., Acked-by (this helps differentiate the footer section from a multi-paragraph body). An exception is made for BREAKING CHANGE, which MAY also be used as a token.

git-interpret-trailers:

When reading trailers, there can be no whitespace before or inside the token, but any number of regular space and tab characters are allowed between the token and the separator.

The default behavior in BitBucket is to use "Approved-By: Ronald Rey", which follows the rules above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant