-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💯 Minor codebase updates and fixes #4008
Labels
Comments
fregante
added
help wanted
meta
Related to Refined GitHub itself
small
Issues that new contributors can pick up
labels
Feb 21, 2021
This was referenced Feb 22, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 15, 2021
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fregante
changed the title
Minor codebase updates and fixes
💯 Minor codebase updates and fixes
Dec 10, 2021
Let's not add any more requests to this issue. A new one can be created. We'll close this one after (almost) everything is done. 🛁 #5222 |
3 tasks
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 17, 2021
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Closing and locking. Thanks for all the fish! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I'll use this issue to add small tasks that could be done, treat it as a wishlist or a good way to start getting acquainted with the codebase.
Find fickle selectors and change them with
select(something more specific).closest(the parent)
;GitHub has been removing some feature-specific classes like
.js-file-list
which means that we end up with monstrosities likemain > :first-child .mt-1 .btn
which mean nothing and could change at any time. Ideally instead we should find the best selector inside the target element (for example its icon,select('.octicon-branch[aria-label="Create branch"]')
) and then reach the desired element with.closest('.btn')
:Better yet: Replace
select().closest()
calls with:has
#4456The text was updated successfully, but these errors were encountered: