Improve feature verification

[fregante]

Most important of all:

• I think we should move the verification to go through Vitest. It will probably look like:

   describe('features', () => {
   	for (const feature of getFeatureMeta() {
   		test(feature.id, () => {
   			// our current tests, but using assert instead of `return "ERR:"`
   		})
   	}
   });

• Document CSS features in readme as well, so that they can be linkified. Example: clean-checks-list. Features can be documented there and hidden via <!-- --> if necessary

• Update rgh-feature-descriptions to show this description

• Add check to verify-features.ts to ensure every .css feature

  • is documented in readme
  • has test URLs

• Move renames to renames.json

• Verify renames in renames.json

  • Old feature names cannot appear anywhere (use grep)
  • New feature names must exist

Originally posted by @fregante in #6000 (comment)

[fregante]

The CSS test-urls check was attempted in #7145 1b7b1828 but was not finalized. It can be continued there.

Edit: On second thought, let's wait until every feature has it, and then just move it to features.test.ts, much easier.

• Move verify-test-urls.sh to Vitest

I don’t think we'll need annotations after every feature has it. Situation 57 missing:

✅ source/features/action-pr-link.tsx
❌ source/features/action-used-by-link.tsx
✅ source/features/actionable-pr-view-file.tsx
❌ source/features/align-issue-labels.tsx
✅ source/features/archive-forks-link.tsx
✅ source/features/avoid-accidental-submissions.tsx
✅ source/features/batch-mark-files-as-viewed.tsx
✅ source/features/bugs-tab.tsx
✅ source/features/ci-link.tsx
✅ source/features/clean-conversation-filters.tsx
✅ source/features/clean-conversation-headers.tsx
✅ source/features/clean-conversation-sidebar.tsx
❌ source/features/clean-pinned-issues.tsx
✅ source/features/clean-readme-url.tsx
✅ source/features/clean-repo-filelist-actions.tsx
✅ source/features/clean-repo-sidebar.tsx
✅ source/features/clean-repo-tabs.tsx
✅ source/features/clean-rich-text-editor.tsx
✅ source/features/clear-pr-merge-commit-message.tsx
✅ source/features/close-as-unplanned.tsx
❌ source/features/close-out-of-view-modals.tsx
✅ source/features/closing-remarks.tsx
✅ source/features/collapsible-content-button.tsx
❌ source/features/command-palette-navigation-shortcuts.tsx
❌ source/features/comment-fields-keyboard-shortcuts.tsx
❌ source/features/comment-on-draft-pr-indicator.tsx
✅ source/features/comments-time-machine-links.tsx
✅ source/features/conflict-marker.tsx
✅ source/features/conversation-activity-filter.tsx
✅ source/features/conversation-links-on-repo-lists.tsx
❌ source/features/convert-pr-to-draft-improvements.tsx
✅ source/features/convert-release-to-draft.tsx
✅ source/features/copy-on-y.tsx
✅ source/features/create-release-shortcut.tsx
❌ source/features/cross-deleted-pr-branches.tsx
✅ source/features/deep-reblame.tsx
✅ source/features/default-branch-button.tsx
✅ source/features/dim-bots.tsx
✅ source/features/download-folder-button.tsx
✅ source/features/easy-toggle-commit-messages.tsx
✅ source/features/easy-toggle-files.tsx
✅ source/features/embed-gist-inline.tsx
✅ source/features/embed-gist-via-iframe.tsx
❌ source/features/emphasize-draft-pr-label.tsx
❌ source/features/esc-to-cancel.tsx
❌ source/features/esc-to-deselect-line.tsx
✅ source/features/expand-all-hidden-comments.tsx
❌ source/features/extend-conversation-status-filters.tsx
❌ source/features/extend-diff-expander.tsx
✅ source/features/file-age-color.tsx
✅ source/features/fit-textareas.tsx
✅ source/features/fix-no-pr-search.tsx
✅ source/features/github-actions-indicators.tsx
❌ source/features/global-conversation-list-filters.tsx
✅ source/features/hidden-review-comments-indicator.tsx
❌ source/features/hide-diff-signs.tsx
❌ source/features/hide-inactive-deployments.tsx
❌ source/features/hide-issue-list-autocomplete.tsx
✅ source/features/hide-low-quality-comments.tsx
✅ source/features/hide-navigation-hover-highlight.tsx
❌ source/features/hide-newsfeed-noise.tsx
✅ source/features/hide-user-forks.tsx
✅ source/features/highest-rated-comment.tsx
✅ source/features/highlight-collaborators-and-own-conversations.tsx
✅ source/features/highlight-non-default-base-branch.tsx
❌ source/features/html-preview-link.tsx
❌ source/features/improve-shortcut-help.tsx
✅ source/features/infinite-scroll.tsx
✅ source/features/jump-to-change-requested-comment.tsx
✅ source/features/jump-to-conversation-close-event.tsx
❌ source/features/keyboard-navigation.tsx
✅ source/features/last-notification-page-button.tsx
✅ source/features/link-to-changelog-file.tsx
✅ source/features/link-to-compare-diff.tsx
✅ source/features/link-to-github-io.tsx
✅ source/features/linkify-branch-references.tsx
✅ source/features/linkify-code.tsx
❌ source/features/linkify-commit-sha.tsx
❌ source/features/linkify-labels-on-dashboard.tsx
✅ source/features/linkify-notification-repository-header.tsx
✅ source/features/linkify-symbolic-links.tsx
❌ source/features/linkify-user-edit-history-popup.tsx
✅ source/features/linkify-user-labels.tsx
✅ source/features/linkify-user-location.tsx
✅ source/features/list-prs-for-branch.tsx
✅ source/features/list-prs-for-file.tsx
✅ source/features/locked-issue.tsx
✅ source/features/mark-merge-commits-in-list.tsx
❌ source/features/mark-private-orgs.tsx
✅ source/features/mobile-tabs.tsx
❌ source/features/more-conversation-filters.tsx
❌ source/features/more-dropdown-links.tsx
✅ source/features/more-file-links.tsx
✅ source/features/netiquette.tsx
✅ source/features/new-or-deleted-file.tsx
✅ source/features/new-repo-disable-projects-and-wikis.tsx
❌ source/features/no-duplicate-list-update-time.tsx
✅ source/features/no-unnecessary-split-diff-view.tsx
✅ source/features/one-click-diff-options.tsx
❌ source/features/one-click-pr-or-gist.tsx
✅ source/features/one-click-review-submission.tsx
❌ source/features/one-key-formatting.tsx
✅ source/features/open-all-conversations.tsx
✅ source/features/open-all-notifications.tsx
❌ source/features/open-issue-to-latest-comment.tsx
✅ source/features/pagination-hotkey.tsx
✅ source/features/parse-backticks.tsx
❌ source/features/patch-diff-links.tsx
✅ source/features/pinned-issues-update-time.tsx
✅ source/features/pr-base-commit.tsx
❌ source/features/pr-branch-auto-delete.tsx
✅ source/features/pr-commit-lines-changed.tsx
✅ source/features/pr-filters.tsx
✅ source/features/pr-jump-to-first-non-viewed-file.tsx
✅ source/features/prevent-comment-loss.tsx
❌ source/features/prevent-duplicate-pr-submission.tsx
❌ source/features/prevent-link-loss.tsx
❌ source/features/prevent-pr-merge-panel-opening.tsx
✅ source/features/preview-hidden-comments.tsx
✅ source/features/previous-next-commit-buttons.tsx
✅ source/features/previous-version.tsx
✅ source/features/profile-gists-link.tsx
✅ source/features/profile-hotkey.tsx
❌ source/features/pull-request-hotkeys.tsx
❌ source/features/quick-comment-edit.tsx
✅ source/features/quick-comment-hiding.tsx
✅ source/features/quick-file-edit.tsx
❌ source/features/quick-label-removal.tsx
✅ source/features/quick-mention.tsx
✅ source/features/quick-new-issue.tsx
✅ source/features/quick-repo-deletion.tsx
❌ source/features/quick-review-comment-deletion.tsx
✅ source/features/quick-review.tsx
✅ source/features/reactions-avatars.tsx
✅ source/features/release-download-count.tsx
✅ source/features/releases-dropdown.tsx
✅ source/features/releases-tab.tsx
❌ source/features/reload-failed-proxied-images.tsx
✅ source/features/repo-age.tsx
✅ source/features/repo-avatars.tsx
✅ source/features/repo-header-info.tsx
✅ source/features/repo-wide-file-finder.tsx
❌ source/features/resolve-conflicts.tsx
✅ source/features/restore-file.tsx
✅ source/features/rgh-dim-commits.tsx
✅ source/features/rgh-feature-descriptions.tsx
✅ source/features/rgh-improve-new-issue-form.tsx
✅ source/features/rgh-linkify-features.tsx
✅ source/features/rgh-linkify-yolo-issues.tsx
✅ source/features/rgh-netiquette.tsx
✅ source/features/rgh-pr-template.tsx
❌ source/features/rgh-welcome-issue.tsx
❌ source/features/same-branch-author-commits.tsx
❌ source/features/scrollable-areas.tsx
✅ source/features/select-all-notifications-shortcut.tsx
✅ source/features/select-notifications.tsx
✅ source/features/selection-in-new-tab.tsx
✅ source/features/shorten-links.tsx
✅ source/features/show-associated-branch-prs-on-fork.tsx
✅ source/features/show-names.tsx
✅ source/features/show-open-prs-of-forks.tsx
❌ source/features/show-user-top-repositories.tsx
✅ source/features/show-whitespace.tsx
✅ source/features/small-user-avatars.tsx
❌ source/features/sort-conversations-by-update-time.tsx
✅ source/features/status-subscription.tsx
✅ source/features/sticky-sidebar.tsx
❌ source/features/stop-redirecting-in-notification-bar.tsx
❌ source/features/submission-via-ctrl-enter-everywhere.tsx
❌ source/features/suggest-commit-title-limit.tsx
✅ source/features/swap-branches-on-compare.tsx
❌ source/features/sync-pr-commit-title.tsx
❌ source/features/tab-to-indent.tsx
✅ source/features/table-input.tsx
✅ source/features/tag-changes-link.tsx
✅ source/features/tags-on-commits-list.tsx
❌ source/features/toggle-everything-with-alt.tsx
✅ source/features/toggle-files-button.tsx
❌ source/features/unfinished-comments.tsx
✅ source/features/unreleased-commits.tsx
✅ source/features/unwrap-unnecessary-dropdowns.tsx
✅ source/features/update-pr-from-base-branch.tsx
✅ source/features/use-first-commit-message-for-new-prs.tsx
✅ source/features/useful-not-found-page.tsx
✅ source/features/user-local-time.tsx
✅ source/features/user-profile-follower-badge.tsx
✅ source/features/vertical-front-matter.tsx
✅ source/features/view-last-pr-deployment.tsx
✅ source/features/visit-tag.tsx
✅ source/features/wait-for-checks.tsx
❌ source/features/warn-pr-from-master.tsx
❌ source/features/warning-for-disallow-edits.tsx

[fregante]

The test URLs check is failing on the GitHub bugs CSS file: #7189

• exclude that file