Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight-collaborators-and-own-conversations bad wrapping #7360

Open
mathomp4 opened this issue May 13, 2024 · 4 comments
Open

highlight-collaborators-and-own-conversations bad wrapping #7360

mathomp4 opened this issue May 13, 2024 · 4 comments
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@mathomp4
Copy link

Description

I'm loving this extension, but I'm seeing an oddity on one of my repos. Here is an example screenshot:

Screenshot 2024-05-13 at 3 23 28 PM

For some PRs, the nice "user oval" thing is split into two lines. I clicked the "Find feature" button and it said:

"The change or issue is caused by warning-for-disallow-edits."

but when I disabled that, it didn't change anything. So I'm at a loss.

How to replicate the issue + URL

I see this issue at this URL:

https://github.com/GEOS-ESM/MAPL/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aopen

but, interestingly, not at the "generic" PR URL:

https://github.com/GEOS-ESM/MAPL/pulls

So perhaps it's being caused by the extra bits at the end there?

Extension version

24.4.9

Browser(s) used

Chrome 124.0.6367.202 Arm64 macOS

@mathomp4 mathomp4 added the bug label May 13, 2024
@fregante
Copy link
Member

This is most likely caused by the added branch to the right. I forgot the name of the feature. Technically it's GitHub's poor layout setup for the PR line that's causing this bad wrapping. We can't try to fix it because we're then more likely to introduce bugs down the line.

@fregante fregante added help wanted small Issues that new contributors can pick up labels May 14, 2024
@fregante
Copy link
Member

I think this specific issue can be fixed by avoiding the wrap inside the bubble, even if it might push the issue elsewhere 👍

@mathomp4
Copy link
Author

Ahh. Okay. That would be highlight-non-default-base-branch. And if I turn that off, the oval is no longer split. I do like that (since pretty much all the PRs in that repo are to non-default branches), but not crucial.

Ah well.

@mathomp4
Copy link
Author

I guess the other way is: Do you know what feature adds the bubble?

@fregante fregante changed the title Odd Split Username Oval...Thing highlight-non-default-base-branch bad wrapping May 23, 2024
@fregante fregante changed the title highlight-non-default-base-branch bad wrapping highlight-collaborators-and-own-conversations bad wrapping May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

2 participants