-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in tutorial with references #3198
Comments
Yes, this need fixing. I would probably go with
Agreed.
I'm not sure I'm in favor of this. Because if you want to run local run-only tests you can even go without dealing with the configuration. Configuration it's a whole chapter of its own and if it comes first, I think the point about how writing tests will be missed. The idea is to introduce the necessary parts of the configuration as the reader progresses with the tutorial.
Agreed, but I would rather make the reader aware of this possibility and point them to the reference for more examples. |
@vkarak I'll take a look on Monday to submit a patch. |
I'll push it back a bit until the end of the week. |
No rush, thanks! |
Deals with reframe-hpc#3198. Also corrects a mischaracterization of `builtin`; it is not a partition, it is an environment.
In https://reframe-hpc.readthedocs.io/en/stable/tutorial.html#adding-performance-references there's a definition for
myhost:baseline
. But as I've discovered after testing, it is more likemysystem:mypartition
.This becomes more confusing since later in the tutorial (see https://reframe-hpc.readthedocs.io/en/stable/tutorial.html#id11) a baseline.py configuration is shown where a hostname
myhost
is defined for themytutorialsys
system and an environment with namebaseline
. The correct reference for that would bemytutorialsys:default
.There are three related issues overall with the presentation:
mysystem:mypartition
for references and needs to be fixed in the tutorial.valid_prog_environs
is not clearly explained. It took me a while to figure out how to request two features, (withvalid_prog_environs = ['+A +B']
.) In retrospect, it is explained in https://reframe-hpc.readthedocs.io/en/stable/regression_test_api.html#reframe.core.pipeline.RegressionTest.valid_systems but it would be nice if the example showed more than just one feature.If you agree with these issues I can fix them.
The text was updated successfully, but these errors were encountered: