Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using s3 publish plugin without cretendtials #141

Open
larionov opened this issue Dec 18, 2018 · 11 comments
Open

Using s3 publish plugin without cretendtials #141

larionov opened this issue Dec 18, 2018 · 11 comments

Comments

@larionov
Copy link

Is it possible to allow reg-publish-s3-plugin to work in the read-only mode without credentials?

In our setup developers don't have access to the S3 credentials, it is only allowed on CI.
That makes us unable to run reg-suit locally but I would like to.

@Quramy
Copy link
Member

Quramy commented Dec 18, 2018

You can’t.

Publish plug-in is designed to put snapshot images to external storage. Why do you want to run reg-suit locally?

We recommend to run the following tasks at CI env:

  • capture screenshot images of your app
  • visual regression test( reg-suit does this)

@larionov
Copy link
Author

To check for the changes made without pushing to repository.

No need to write the image data to s3 in that case.

@Quramy
Copy link
Member

Quramy commented Dec 18, 2018

reg-suit sync-expected command may help you. It only fetches uploaded images.

And you can compare actual images and fetched images with reg-suit compare command.

@larionov
Copy link
Author

I tried that and to fetch the images the s3 command requires s3 credentials, which I don't have. But the image data is available on s3 publicly

@Quramy
Copy link
Member

Quramy commented Dec 18, 2018

The compare command outputs an HTML report under .reg dir.

@Quramy
Copy link
Member

Quramy commented Dec 18, 2018

Oh... sync-expexted cmd uses AWS-SDK and it requires a credential...
Can you get read-only credentials?

@larionov
Copy link
Author

I would prefer not to have to do that because then every team member will have to go and get them, and that's not an easy process.

@Quramy
Copy link
Member

Quramy commented Dec 18, 2018

We need to use SDK to fetches the list of uploaded images. If you have alternative way to get the finelame URL list, you can download images with simple http CLI, for example cURL.

@larionov
Copy link
Author

Do you think making a publish plug-in that works with git instead of s3 is a good idea?
One drawback I see is it's harder to publish the report

@larionov
Copy link
Author

Also found out that using git hash + s3 as source for the screenshots to compare to can be unreliable if the parent branch fails the build.
Now it doesn't have anything to compare to and thinks all the screenshots are new.
Not sure how that can be fixed though.

@ryparker
Copy link

I am also in the same boat as @larionov . We would like devs to be able to pull images from s3 without creds to then test locally before submitting a PR. Writing a script to pull from s3 would be easy however since we use the git-hash-keygen-plugin, the difficult part is knowing the correct key to pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants