Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isTSConfigPreReq and isExistsTSConfig checks #1056

Open
egorio opened this issue May 17, 2023 · 0 comments
Open

Improve isTSConfigPreReq and isExistsTSConfig checks #1056

egorio opened this issue May 17, 2023 · 0 comments
Assignees
@lynchbomb
Labels
bug Something isn't working early-adopters Ultra-Priority flagged from early adopter
Milestone
Typing the Intern...

Comments

@egorio
Copy link
Contributor

egorio commented May 17, 2023 •
edited

We currently check for tsconfig.json only in the root directory, ignoring settings from package's dir.

TS has a function to search for tsconfig file

Another improvement is to check glint config recursively. We can ask glint team to export loadConfig and use its results.
@egorio egorio added the bug Something isn't working label May 17, 2023
@egorio egorio added this to the 4. Self Service milestone May 17, 2023
@egorio egorio mentioned this issue May 17, 2023
Merged
@lynchbomb lynchbomb self-assigned this May 18, 2023
@lynchbomb lynchbomb added the early-adopters Ultra-Priority flagged from early adopter label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lynchbomb lynchbomb

Labels
bug Something isn't working early-adopters Ultra-Priority flagged from early adopter
Projects
None yet
Milestone
Typing the Internal Dep Stack
Development

No branches or pull requests
3 participants
@mikesherov @egorio @lynchbomb