Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: type inference for destructured parameters doesn't work in some cases #1062

Open
egorio opened this issue May 18, 2023 · 0 comments
Open

bug: type inference for destructured parameters doesn't work in some cases #1062

egorio opened this issue May 18, 2023 · 0 comments
Assignees
@egorio
Labels
bug Something isn't working early-adopters Ultra-Priority flagged from early adopter
Milestone
Typing the Intern...

Comments

@egorio
Copy link
Contributor

egorio commented May 18, 2023

See last 2 cases in https://github.com/rehearsal-js/rehearsal-js/blob/master/packages/codefixes/test/fixtures/base-codefixes/annotateWithStrictTypeFromJSDoc/index.ts.

The inferenceOfDestructuredParams has types inferred while the issueWithTheReturnType doesn't.

The issues is possibly related to findTargetNode.
@egorio egorio added the bug Something isn't working label May 18, 2023
@egorio egorio added this to the 4. Self Service milestone May 18, 2023
@egorio egorio mentioned this issue May 18, 2023
Merged
1 task
@lynchbomb lynchbomb added the early-adopters Ultra-Priority flagged from early adopter label May 18, 2023
@egorio egorio changed the title bug: type inference for destructured parameters in some cases don't work bug: type inference for destructured parameters doesn't work in some cases May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egorio egorio

Labels
bug Something isn't working early-adopters Ultra-Priority flagged from early adopter
Projects
None yet
Milestone
Typing the Internal Dep Stack
Development

No branches or pull requests
3 participants
@mikesherov @egorio @lynchbomb