Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glint.fix refactoring to use rehearsal collections of codefixes #1084

Open
egorio opened this issue May 23, 2023 · 0 comments
Open

Glint.fix refactoring to use rehearsal collections of codefixes #1084

egorio opened this issue May 23, 2023 · 0 comments
Labels
early-adopters Ultra-Priority flagged from early adopter enhancement New feature or request

Comments

@egorio
Copy link
Contributor

egorio commented May 23, 2023

Glint service provides a function getDiagnostics which is used by glint.fix plugin. The getDiagnostics function combines TS diagnostics together with glint ones, and does some post-processing. Unfortunately, this prevents us from using rehearsal-provided codefixes and requires duplicating the code from ts-codefixes.

The good part is that glint exposes a transformManager which allows us to reproduce getDiagnostics outside of glint.

This means we can try to implement glint-codefixes-collection to return glint-specific codefixes and consume base-codefixes and ts-codefixes directly from rehearsal source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-adopters Ultra-Priority flagged from early adopter enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants