New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: service-map.json is used different way in fix and graph #1120

Open

egorio opened this issue Jun 8, 2023 · 0 comments

Labels

bug

Contributor

egorio commented Jun 8, 2023 •

edited

Comparing 2 commands I found that service-map.json is consumed differently:

The graph is searching for service-map file only in the rootPath while the fix is using find-up to find it.
The graph is searching for services on the map as serviceMap[keyName] while the fix expect the key to be in one of the following formats: kebab, camel-case or just plain string

It's better to move the logic behind service-map to a separate class and share it between fix and graph

The text was updated successfully, but these errors were encountered:

egorio self-assigned this

egorio added the bug label

egorio removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment