Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get width and height from bounding client rect #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

get width and height from bounding client rect #28

wants to merge 1 commit into from

Conversation

osdiab
Copy link

@osdiab osdiab commented Mar 4, 2020 •
edited

Closes #25

I think this closes #21 : after trying it on a path in an SVG element on my site it appears to be returning a sensical value

@osdiab osdiab mentioned this pull request Mar 4, 2020
Open
@dariye
Copy link

dariye commented Mar 6, 2020

Would be great to have this merged 😍

@osdiab osdiab changed the title get width and height from boundign client rect get width and height from bounding client rect Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-fyodorov al-fyodorov al-fyodorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use width and height from getBoundingClientRect Does not work with SVG elements
3 participants
@osdiab @dariye @al-fyodorov