New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error applying minor version label #1011
Comments
Instead of a screenshot, can you please go to the github action and take the text form? |
We only do a single increment. |
Here's the stack trace:
I shared the screenshot so you knew the context of where the error was being reported. Thought it would be easy enough to find where release-drafter/lib/releases.js Line 241 in 8e4c08c
|
Just want to drop a quick note here to say that our repos that use
and we are not using a "minor" label, so that detail is probably not central to the breakage. I have restored things to working order in a repo by locking the version to For those who want to use this workaround, here's what I did: I changed
to
and on my next merge to my main branch all worked as expected. (heads up @KevinBatdorf in case this helps you) |
@darrentorpey I reverted v5 tag to point to v5.15.0 so it should be fine. So our tests are passing but I guess we do not have a tests with pull requests that has no labels 😅
Nope screenshot is the worst form of info sharing :D I cannot see the surrounding context. |
The line number release-drafter/lib/releases.js Line 234 in 8e4c08c
Which is unchanged for the past 2 years 🗡️ I see we have zero test coverage of this function apart from the index tests that touches it. |
Odd. I'd offer to help test a fix you might be thinking of but not sure how I could. The two files I shared at the start are unedited so maybe it's reproducible? That plus the labels on the PR seem like everything involved. We'll likely do another release next week or the following and I can report back then too. Must be a change after |
Could be related to #973 but even than the default config has empty labels for each key 😖 |
I'm just throwing out ideas but maybe this change to a Set caused a regression elsewhere? 1f825d3#diff-191fd5fc5599fadfab5a79d6590a13d1c252404a84be653223c41c381c55498bR124-R126 |
We are using version-resolver and dogfooding our action on master branch and the action passes: 😕 release-drafter/.github/release-drafter.yml Lines 21 to 34 in 8e4c08c
|
Have you tried a PR with only the labels If still ok, then it would have to be the other config items that differ, right? I mostly used boilerplate from the example I think. |
@KevinBatdorf if you add a major section to your version-resolver I suspect it will work. I believe it is #973 it is not performing a deep merge of the defaults. So it should have defaulted to |
Yup a unit test is able to reproduce your error message with a partial config. |
Would it be better to make that an optional property you think? |
Nah, the default config ensure our code base works as expected on objects without too much conditional code logic :) See #1012 |
v5 is updated with the fix :) |
Got an error when the workflow had a
minor
label appliedI have a general question to. If we add a
minor
label to multiple PRs will it continuously bump the version number? Or is it only one bump per release? ThanksThe text was updated successfully, but these errors were encountered: