Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure PRs are merged #1015

Merged
merged 2 commits into from Jan 16, 2022
Merged

ensure PRs are merged #1015

merged 2 commits into from Jan 16, 2022

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jan 16, 2022

fixes #766
fixes #917

@@ -50,7 +50,7 @@
"mocked-env": "^1.3.5",
"nock": "13.2.2",
"nock-knock": "2.0.0",
"node-fetch": "3.1.0",
"node-fetch": "2.6.7",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1.0 is an ESM module, which we cannot use yet.

@jetersen jetersen merged commit d51d5d1 into release-drafter:master Jan 16, 2022
@jetersen jetersen deleted the fix/ensurePRsAreMerged branch January 16, 2022 16:43
@jetersen jetersen added the type: bug Something isn't working label Jan 16, 2022
rnorth added a commit to testcontainers/testcontainers-java that referenced this pull request Mar 9, 2022
* includes new `collapse-after` mode to automatically collapse long lists of dependency updates
* includes a fix for unmerged PRs sometimes appearing (release-drafter/release-drafter#1015)
* renamed GHA workflow file for DX reasons: the previous filename was being identified for JSON schema validation as a release drafter config file rather than as a GHA workflow. With the changed filename, IDE validation and autocompletion are now actually helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Drafter is *sometimes* including unmerged PRs unmerged PRs listed on changelog
1 participant