$RESOLVED_VERSION not expanded when set via action input

[mkurz]

Using the name input:

...
jobs:
  update_release_draft:
    runs-on: ubuntu-latest
    steps:
      - uses: release-drafter/release-drafter@v5
        with:
          name: "$RESOLVED_VERSION"
...

the release draft will be named $RESOLVED_VERSION, which obviously is not what I expected.

However inside the config file

name-template: '$RESOLVED_VERSION'

the release draft will correctly be named with the version, e.g. 1.0.0.

Now, the name overrides the name-template:

I expect both configs behave identically, I would have guessed variable expansion takes places after the override happened, so it shouldn't matter where the config string came from.

[jetersen]

Maybe but what's wrong with using name-template?

[mkurz]

Nothing wrong with using name-template, however I am setting up a generic release draft in our org's .github repo and in various other repos I set up workflows that reference that base.yml draft, and want to use the specific project name as title of the release.
For example:
repoA has the workflow:

...
        with:
          name: "Project A $RESOLVED_VERSION"
...

repoB has the workflow

...
        with:
          name: "Project B $RESOLVED_VERSION"
...

BTW: I tried to achieve that with env variables, by passing the project name to the base file, but that doesn't working (#847). Actually for our needs using $RESOLVED_VERSION would be enough.

[jetersen]

Right make sense, would welcome a PR :)

[mkurz]

Sure, I hope I find time.

[jetersen]

You should have access to $REPO and $OWNER maybe I made a mistake and did not allow it to be expanded in name-template and tag-template most likely for tag-template it should lowercase or simply not be possible?

[mkurz]

(Closed by accident)

I just tried again, $RESOLVED_VERSION does work when used in name-template.
It does not work when name-template gets overriden by the name input:

That's what I see in https://github.com/playframework/twirl/releases right now (name: "Twirl $RESOLVED_VERSION"):

That's what I saw a couple of minutes before adding the name input, so there was only name-template: 'Version $RESOLVED_VERSION':

So we do have access to $RESOLVED_VERSION in name-template, but not when it is overriden with the name action input.

[jetersen]

So we do have access to $RESOLVED_VERSION in name-template, but not when it is overriden with the name action input.

Exactly

[mkurz]

@jetersen Here is the fix #1049, wasn't too hard.