New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release-drafter gets HTTP 500 error when trying to fetch more than 1000 releases #1082
Comments
Would love to see a PR for fixing it. We could set an limit on something reasonable like 500 or just max it to 1000. It seems doable: release-drafter/lib/releases.js Lines 25 to 31 in bd3f0d7
See the use of done in the example here: https://michaelheap.com/octokit-pagination/ |
Seems to be around the same time as #1081 |
Hey, we experienced this issue with the 500 HTTP response, as a quick workaround for now we have applied this. |
@eddmann feel free to open a PR :) |
this is also happening to us. @jetersen when are you planning to release the patch? |
You can point to master to the time being. |
Release Drafter stops working for repositories that have more then 1000 releases so far. I found a bug reported in release-drafter repo . It was fixed already and merged into master. Therefore we point to master branch until new release is coming out release-drafter/release-drafter#1082
This looks to have been addressed upstream within the GitHub API, so this fix can be removed 👍🏻 |
Going to (try to) report this to Github as well, but posting a bug report here first so others hopefully aren't left wondering if they were crazy.
The Issue
Sometime between 2022-02-23 17:37:24 GMT and 2022-02-23 21:33:53 GMT, the Github API started returning 500 errors when you try to retrieve past 1000 releases. We discovered this because the
release-drafter
Github action suddenly stopped working in that time frame.Here is a Github Action log snippet from before, when
release-drafter
found our 1227 releases just fine:The next time someone pushed a commit was a few hours later, and every run of
release-drafter
since has failed with this 500 error:Testing the URL with a personal Github token runs into the same issue: as soon as I try to fetch further back than 1000 releases, I get a 500 error.
Note that the
Link
header is still suggesting that these pages are valid to retrieve:The issue seems to be around 1000 releases and not page numbers, as changing the per_page parameter changes where the 500 error pops up.
Environment
I've tried updating to the latest version of
release-drafter
(v5.18.1
), but still get the same behavior, which is not entirely surprising if this is an API issue.We are using
release-drafter
via Github Actions. Our action parameters are extremely basic:As is our
release-drafter.yml
(lightly edited):Note: I am NOT with the official Apache Airflow project. My team are just users of it. This is also happening with a private repository, or I'd provide direct links to the code.
Possible Workaround?
As a workaround for this, is there any way to limit the number of releases that release-drafter tries to fetch? (I realize y'all are not in charge of the Github REST API and don't expect miracles here.)
The text was updated successfully, but these errors were encountered: