Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template variables in tag and name affecting by semver #1184

Open
hernit opened this issue Jul 15, 2022 · 2 comments
Open

Template variables in tag and name affecting by semver #1184

hernit opened this issue Jul 15, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@hernit
Copy link

hernit commented Jul 15, 2022

This bug spans from the feature added in #1049

Semver resolver seems to be confuse when we put variables into tag. If you have set input as tag: v$RESOLVED_VERSION-rc+1234 as allowable with semver with build metadata, drafter will convert that into a template of v1234.0.0-rc.

This is replicable in https://github.com/release-drafter/release-drafter/blob/master/test/index.test.js#L2540 if you change RC1 to RC1234, the test will break.

@jetersen
Copy link
Member

Pull request are welcomed ☺️

@jetersen jetersen added the help wanted Extra attention is needed label Jul 15, 2022
@shadycuz
Copy link

shadycuz commented Oct 1, 2022

I was about to open my own issue, but this looks similar to the issue I am having.

My release looks like this:

but the tag and the name should be exactly the same value. Here is the relevant release-drafter.yml:

name-template: 'v$INPUT_VERSION'
tag-template: 'v$INPUT_VERSION'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants