Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comments about pull requests permission #1187

Merged
merged 1 commit into from Jul 31, 2022
Merged

Add more comments about pull requests permission #1187

merged 1 commit into from Jul 31, 2022

Conversation

Kirade
Copy link
Contributor

@Kirade Kirade commented Jul 22, 2022

Hi,

README introduces that permission required by pull-requests should be write when to add label to PR.
pull-requests: write # for release-drafter/release-drafter to add label to PR

I think this comment can mislead some users to think they can remove this option, if they don't need add label functionality.
After remove this option. release-drafter complains about permissions. (related issue)

So I suggest to add more information about permission.
which introduces write permission is optional for autolabeler and read permission is required at least.

Thanks.

@jetersen jetersen merged commit d243e04 into release-drafter:master Jul 31, 2022
@Kirade Kirade deleted the release-drafter-permission-docs branch August 1, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants