Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flag to consider pre-release version when drafting new release #1293

Closed
rchristilaw opened this issue Jan 9, 2023 · 4 comments · Fixed by #1302
Closed

Introduce flag to consider pre-release version when drafting new release #1293

rchristilaw opened this issue Jan 9, 2023 · 4 comments · Fixed by #1302

Comments

@rchristilaw
Copy link

The changes in #1240, which removed the latest pre-release version from consideration when drafting a new release has introduced problems for my worklow. In my workflow use case, I create a new pre-release which does not get released right away. This is resulting in the new draft release being named the same as the pending pre-release.

Example:
v1.2 (Latest Released Version)
v1.3 (Pre-release pending release)

While v1.3 still has not been released, a new draft release is created, but since v1.2 is the latest release, and v1.3 prerelease is now ignored, a new draft release named v1.3 is created, rather than a version v1.4.

The ask is that a config flag is created which will allow for consideration of pre-releases when resolving a new version, and allows release-drafter to function as it did prior to Release v5.22.

@tcyran
Copy link

tcyran commented Jan 11, 2023

We are having exact same issue as @rchristilaw

From logical point of view of how action this behaviour is simply wrong. There should be a flag which consider ignoring pre-release and if such flag is enabled there should be also option to automatically remove conflicting pre-release version to avoid action to fail.

Also I would consider if such change should be considered as minor release, as many ppl could build their workflow base on previous behavior. So IMHO it's major release as it's breaking change :)

@vdubovets
Copy link

+1, We've faced the same issue. It breaks our existing logic as our deployment flow depends on prerelease label.
Having the config flag that adds prereleases into the filter would be nice.
Thanks!

@ranger-ross
Copy link

ranger-ross commented Jan 13, 2023

+1, This broke my team's workflow as well.
I believe this should have been a breaking change due to the behavior, or made this behavior opt-in.

For those who's workflows are now broken, you can force the previous version with the following code in you GitHub Action

uses: release-drafter/release-drafter@v5.21.1

This fixes the issue in my project

@robbinjanssen
Copy link
Contributor

I've created a pull request #1302 where you can config this behaviour. The default functionality will be the same as introduced by #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants