Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure this with gitflow? #175

Closed
thibmaek opened this issue Apr 10, 2019 · 9 comments
Closed

How to configure this with gitflow? #175

thibmaek opened this issue Apr 10, 2019 · 9 comments

Comments

@thibmaek
Copy link

I tried, really. But I didn't find a way to create the release.

Our repo has base branch set to develop, but I only want to create releases for code ending up on master.

Relevant Release Drafter config: https://github.com/inthepocket/hubble-scripts/blob/develop/.github/release-drafter.yml

Tried first with merging remotes into master and pushing, then tried to merge via PR from develop to master, but the release is not showing up as a Draft when I go to the releases tab.

image

@jetersen
Copy link
Member

Change your default branch to master?

Or perhaps we should provide a way to override the default branch.

@thibmaek
Copy link
Author

That would mean all the PRs point at master by default and checking out the repo across team members starts from master. Kind of defeats the purposes of gitflow I think

@sullimander
Copy link

We would need the ability to set the release branch separate from the github default branch in order for us to use it.

@TimonVS
Copy link
Member

TimonVS commented Apr 25, 2019

Can you walk me through the issue you're having in a little more detail? I can see that you used the branches option in your config, why doesn't that give the desired result?

@StewartSnow
Copy link

StewartSnow commented May 15, 2019

Hey we have the same issue here - we follow gitflow and would prefer that all draft releases are created on the master branch, rather than default develop branch (as is common under gitflow).
An additional config entry to indicate the branch that the release / tag should be drafted on would be most helpful.

Screenshot 2019-05-15 at 13 42 23

Just to elaborate on the issue:

  • We follow GitFlow, and as such the default branch is develop (not master)
  • All feature / fix branches get merged into develop first
  • Develop then gets merged into master for release
  • We have "branches: master" which correctly ensures that release-drafter updates or creates the release notes on the merge into master...
  • However, the draft release it creates is still on develop (despite the master branch being indicated in the config)

@thibmaek
Copy link
Author

This is indeed the same problem I am encountering

@rvanlaak
Copy link

In our gitflow-like scenario we have master setup as develop, and production as master. What we see happening, is that release drafter nicely creates drafts for master`.

A problem we have (that sounds similar to the issue description) happens in the following scenario:

1 - A release branch gets created, testing starts and could take several days
2 - PRs that in the meanwhile get merged in master (read: the gitflow develop) and do not make the release - as they are not in the release branch.
3 - The release branch gets merged in production (read: the gitflow master) and gets tagged.

The actual problem that happened in the meanwhile: the PRs that get merged in step 2 do not appear in the next release draft.

@mkurz
Copy link
Contributor

mkurz commented Mar 24, 2021

I think the problems you are facing can be solved with the filter-by-commitish config, I came up with this comment on how to change the target_commitish of a GitHub release: #656 (comment)

@mkurz
Copy link
Contributor

mkurz commented Feb 7, 2022

You also might be interested in #1061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants