Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$CONTRIBUTORS includes authors of excluded PRs #594

Closed
leouieda opened this issue Jul 17, 2020 · 1 comment
Closed

$CONTRIBUTORS includes authors of excluded PRs #594

leouieda opened this issue Jul 17, 2020 · 1 comment

Comments

@leouieda
Copy link

leouieda commented Jul 17, 2020

The $CONTRIBUTORS variable seems to be including authors of PRs excluded using exclude-labels. For example:

missing-url

Notice that @fatiando-bot isn't included in the changelog but shows up in the contributors list.

With configuration:

# Configuration for the Release Drafter workflow
name-template: 'v$NEXT_PATCH_VERSION'
tag-template: 'v$NEXT_PATCH_VERSION'
change-template: '* $TITLE (#$NUMBER $URL by [@$AUTHOR](https://github.com/$AUTHOR))'
categories:
  - title: 'New functions/classes'
    label: 'feature'
  - title: 'Enhancements'
    label: 'enhancement'
  - title: 'Bug Fixes'
    label: 'bug'
  - title: 'Deprecations'
    label: 'deprecation'
  - title: 'Documentation'
    label: 'documentation'
  - title: 'Maintenance'
    label: 'maintenance'
exclude-labels:
  - 'skip-changelog'
template: |
  [![DOI](https://zenodo.org/badge/DOI/PASTE_DOI_HERE.svg)](https://doi.org/PASTE_DOI_HERE)
  ## Highlights
  * DELETE IF THERE ARE NO HIGHLIGHTS
  $CHANGES
  This release contains contributions from: $CONTRIBUTORS

Note: this is the same code and example from #593 but I thought it would be best to open another issue since it's a separate problem.

@jetersen
Copy link
Member

duplicate of #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants