Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag always ends up on the main-branch #824

Closed
danielcweber opened this issue Mar 26, 2021 · 3 comments · Fixed by #865
Closed

Tag always ends up on the main-branch #824

danielcweber opened this issue Mar 26, 2021 · 3 comments · Fixed by #865

Comments

@danielcweber
Copy link
Contributor

Hi,

first of all, thanks for this great workflow.

I develop on the "main" branch. On a release, I create a branch "rel" and bump the version (in a version.json), thereby creating a new commit). "rel" is now one commit ahead of "main".

I override the "tag" and the "commitish" parameter of the workflow. Commitish seems to successfully pickup "rel" as the branch to work on. Yet, the tag always ends up on "main".

My workflow is here. The latest run is this. Note that I have forcefully pushed the 8.4.0-tag to be on the right commit.

Thanks a lot.

@danielcweber
Copy link
Contributor Author

Apparently, the "commitish" parameter doesn't make it to the "target_commitish" parameter of the createRelease method in OctoKit:

image

I had a thorough look into the sources but can't tell where it gets lost.

@gauravsaini
Copy link

gauravsaini commented May 13, 2021

Facing the same issue.
"main" refers to the default branch here.

wordrak added a commit to lanalabs/release-drafter that referenced this issue Jul 21, 2021
Use commitish from action inputs. Fixes release-drafter#824.
@oncicaradupopovici
Copy link

HI, any news related to the commitish input param? Any way to work-around this issue?

jetersen pushed a commit that referenced this issue Sep 6, 2021
Co-authored-by: Mariusz Kogut <mk@hanmdade-systems.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants