Fix prerelease string getting removed and add $COMPLETE version variable #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
commented
Aug 10, 2021
|
|
||
| expect(versionInfo.$NEXT_MAJOR_VERSION.version).toEqual('11.0.0') | ||
| expect(versionInfo.$NEXT_MINOR_VERSION.version).toEqual('10.1.0') | ||
| expect(versionInfo.$NEXT_PATCH_VERSION.version).toEqual('10.0.4') | ||
| expect(versionInfo.$NEXT_PATCH_VERSION.version).toEqual('10.0.3') |
There was a problem hiding this comment.
This was previously wrong. The next patch version after v10.0.3-alpha is actually 10.0.3 not 10.0.4, but it was becoming 10.0.4 before because 10.0.3-alpha was incorrectly becoming 10.0.3 internally
tjenkinson
added a commit
to video-dev/hls.js
that referenced
this pull request
Aug 10, 2021
tjenkinson
changed the title
|
@tjenkinson A PR merged resulted in some conflict 😅 Could you please take a look? |
|
@jetersen done! |
jetersen
reviewed
Sep 6, 2021
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
jetersen
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the version is a prerelease the prerelease string is discarded because
semver.coercediscards it.With this PR we now use
semver.parseinstead and fall back to coerce.It also updates
splitSemVerto always return a string instead of sometimes aSemVerinstance (which currently becomes a string intemplatedue to it having atoString) and sometimes string.Finally it adds a
$COMPELTEvariable that can be used to access the full version string, otherwise it's still not possible to get the prerelease info in the template.