Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include edited event for autolabeler #931

Conversation

juanecabellob
Copy link
Contributor

@juanecabellob juanecabellob commented Aug 26, 2021

Why

One of the input for the autolabeler is the PR title. If while creating the PR, the title didn't conform with any of the autolabeling rules, changing afterwards does not trigger the autolabeler.

Summary of changes

  • Include the edited event of pull requests.

@juanecabellob
Copy link
Contributor Author

Hi! I'm a bit unsure whether the dist/ folder should be committed or not. Also, i'm surprised by the number of changes that the dist/index.js has. i couldn't find anything in the CONTRIBUTING.md nor in the CODE OF CONDUCT.md so i'm happy to remove it if that's not something part of the process.

@jetersen
Copy link
Member

jetersen commented Aug 26, 2021

I would not expect this many changes to the dist.

Running: yarn install should install the correct dependencies than running yarn prettier && yarn lint --fix && yarn build should than correctly generate the dist folder with few diffs as possible.

@jetersen
Copy link
Member

The GitHub action agrees your dist folder is not what is expected. I suspect you have committed CRLF line endings or used npm to install packages.

@juanecabellob
Copy link
Contributor Author

Is yarn the package manager used? if so, then probably the Contributing guideline is outdated. It says to run npm install 😅. I’ll re install with yarn

@juanecabellob
Copy link
Contributor Author

Thanks for the hints @jetersen. I've updated the PR with correct dist/ and also updated the Contributing guideline accordingly.

@jetersen jetersen merged commit fbb074a into release-drafter:master Sep 6, 2021
@jetersen jetersen added the type: bug Something isn't working label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants