Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parserOpts in the getRecommendedVersion function. #64

Merged
merged 1 commit into from Jul 29, 2023

Conversation

JepriCreations
Copy link
Contributor

In order to make conventionalRecommendedBump(options, [parserOpts,] callback) receive the param parseOpts, it has to be included in the getRecommendedVersion call, if not, it is ignored and it does not detect the correct commitType when parserOpts are passed in the plugin configuration, for example:

release-it config
{ "@release-it/conventional-changelog":{ preset:"angular", parserOpts: { headerPattern: /^(\S*) (\w*)(?:\(([\w$.\-* ]*)\))?: (.*)$/, headerCorrespondence: ['emoji', 'type', 'scope', 'subject'], }, } }

commits
'馃啎 feat: Some new features'

Before this pr:
commitType = 'patch'

After this pr:
commitType = 'minor'

@webpro
Copy link
Contributor

webpro commented Jul 17, 2023

If the reason to close this was me taking too long to respond, then I'm sorry. Happy to look into it, but at my own convenience.

@JepriCreations
Copy link
Contributor Author

Hi,

I apologize for closing the PR. I thought one of the recent updates had fixed the issue, but it turns out that wasn't the case. The PR should still be open.

I'm sorry for any inconvenience this may have caused. Thank you for your work and time.

@webpro webpro merged commit a4acfea into release-it:master Jul 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants