Skip to content

Commit

Permalink
Strict Node.js v10 support (#892)
Browse files Browse the repository at this point in the history
* Enable strict engine checks and downgrade dependencies accordingly

* Add resolutions for lru-cache (Yarn)
  • Loading branch information
webpro committed Apr 11, 2022
1 parent 4236733 commit 43d74fe
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
1 change: 1 addition & 0 deletions .npmrc
@@ -1 +1,2 @@
save-exact=true
engine-strict=true
11 changes: 6 additions & 5 deletions lib/plugin/gitlab/GitLab.js
Expand Up @@ -29,7 +29,7 @@ class GitLab extends Release {
const { tokenHeader } = this.options;
const { baseUrl } = this.getContext();
this._client = got.extend({
prefixUrl: baseUrl,
baseUrl,
method: 'POST',
headers: {
'user-agent': 'webpro/release-it',
Expand Down Expand Up @@ -128,7 +128,7 @@ class GitLab extends Release {
const requests = releaseMilestones.map(milestone => {
const options = {
method: 'GET',
searchParams: {
query: {
title: milestone,
include_parent_milestones: true
}
Expand Down Expand Up @@ -210,21 +210,22 @@ class GitLab extends Release {

const endpoint = `projects/${id}/releases`;
const options = {
json: {
json: true,
body: {
name,
tag_name: tagName,
description
}
};

if (this.assets.length) {
options.json.assets = {
options.body.assets = {
links: this.assets
};
}

if (releaseMilestones.length) {
options.json.milestones = releaseMilestones;
options.body.milestones = releaseMilestones;
}

try {
Expand Down
9 changes: 6 additions & 3 deletions package.json
Expand Up @@ -65,7 +65,7 @@
"form-data": "4.0.0",
"git-url-parse": "11.6.0",
"globby": "11.0.4",
"got": "11.8.3",
"got": "9.6.0",
"import-cwd": "3.0.0",
"inquirer": "8.2.0",
"is-ci": "3.0.1",
Expand All @@ -77,7 +77,7 @@
"os-name": "4.0.1",
"parse-json": "5.2.0",
"promise.allsettled": "1.0.5",
"semver": "7.3.6",
"semver": "7.3.5",
"shelljs": "0.8.5",
"update-notifier": "5.1.0",
"url-join": "4.0.1",
Expand All @@ -91,7 +91,7 @@
"ava": "3.15.0",
"eslint": "7.32.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-ava": "13.2.0",
"eslint-plugin-ava": "12.0.0",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-prettier": "4.0.0",
"markdown-toc": "1.2.0",
Expand All @@ -106,5 +106,8 @@
},
"engines": {
"node": ">=10"
},
"resolutions": {
"lru-cache": "6.0.0"
}
}

0 comments on commit 43d74fe

Please sign in to comment.