Defer dry run bail out in asset globbing (to include the warning in d…

…ry runs)
release-it · Sep 15, 2022 · bf6ccc8 · bf6ccc8
1 parent feff2eb
commit bf6ccc8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/plugin/github/GitHub.js b/lib/plugin/github/GitHub.js
@@ -286,14 +286,17 @@ class GitHub extends Release {
 
     this.log.exec('octokit repos.uploadReleaseAssets', patterns, { isDryRun });
 
-    if (!assets || !isReleased || isDryRun) {
+    if (!assets || !isReleased) {
       return true;
     }
 
     return globby(patterns).then(files => {
       if (!files.length) {
         this.log.warn(`octokit repos.uploadReleaseAssets: did not find "${assets}" relative to ${process.cwd()}`);
       }
+
+      if (isDryRun) return Promise.resolve();
+
       return Promise.all(files.map(filePath => this.uploadAsset(filePath)));
     });
   }

diff --git a/lib/plugin/gitlab/GitLab.js b/lib/plugin/gitlab/GitLab.js
@@ -257,14 +257,17 @@ class GitLab extends Release {
 
     this.log.exec('gitlab releases#uploadAssets', patterns, { isDryRun });
 
-    if (!assets || isDryRun) {
+    if (!assets) {
       return noop;
     }
 
     return globby(patterns).then(files => {
       if (!files.length) {
         this.log.warn(`gitlab releases#uploadAssets: could not find "${assets}" relative to ${process.cwd()}`);
       }
+
+      if (isDryRun) return Promise.resolve();
+
       return Promise.all(files.map(filePath => this.uploadAsset(filePath)));
     });
   }