diff --git a/lib/plugin/github/GitHub.js b/lib/plugin/github/GitHub.js index e2f42e3a..0b5513ac 100644 --- a/lib/plugin/github/GitHub.js +++ b/lib/plugin/github/GitHub.js @@ -286,7 +286,7 @@ class GitHub extends Release { this.log.exec('octokit repos.uploadReleaseAssets', patterns, { isDryRun }); - if (!assets || !isReleased || isDryRun) { + if (!assets || !isReleased) { return true; } @@ -294,6 +294,9 @@ class GitHub extends Release { if (!files.length) { this.log.warn(`octokit repos.uploadReleaseAssets: did not find "${assets}" relative to ${process.cwd()}`); } + + if (isDryRun) return Promise.resolve(); + return Promise.all(files.map(filePath => this.uploadAsset(filePath))); }); } diff --git a/lib/plugin/gitlab/GitLab.js b/lib/plugin/gitlab/GitLab.js index fac51ba6..278f1858 100644 --- a/lib/plugin/gitlab/GitLab.js +++ b/lib/plugin/gitlab/GitLab.js @@ -257,7 +257,7 @@ class GitLab extends Release { this.log.exec('gitlab releases#uploadAssets', patterns, { isDryRun }); - if (!assets || isDryRun) { + if (!assets) { return noop; } @@ -265,6 +265,9 @@ class GitLab extends Release { if (!files.length) { this.log.warn(`gitlab releases#uploadAssets: could not find "${assets}" relative to ${process.cwd()}`); } + + if (isDryRun) return Promise.resolve(); + return Promise.all(files.map(filePath => this.uploadAsset(filePath))); }); }