Skip publish prompt when package.json has private: true (fixes #936)

release-it · Mar 9, 2023 · d816d40 · d816d40
1 parent 56787b5
commit d816d40
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/plugin/npm/npm.js b/lib/plugin/npm/npm.js
@@ -91,6 +91,7 @@ class npm extends Plugin {
 
   release() {
     if (this.options.publish === false) return false;
+    if (this.getContext('private')) return false;
     const publish = () => this.publish({ otpCallback });
     const otpCallback =
       this.config.isCI && !this.config.isPromptOnlyVersion ? null : task => this.step({ prompt: 'otp', task });

diff --git a/test/tasks.js b/test/tasks.js
@@ -384,7 +384,7 @@ test.serial('should handle private package correctly, bump lockfile', async t =>
   const npmArgs = getArgs(container.shell.exec.args, 'npm');
   t.deepEqual(npmArgs, ['npm version 1.0.1 --no-git-tag-version']);
   t.true(log.obtrusive.firstCall.args[0].endsWith(`release ${pkgName} (1.0.0...1.0.1)`));
-  t.is(log.warn.lastCall.args[0], 'Skip publish: package is private.');
+  t.is(log.warn.length, 0);
   t.regex(log.log.firstCall.args[0], /Done \(in [0-9]+s\.\)/);
 
   exec.restore();