New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: name of param to enable comment functionality #1046

Merged

webpro merged 1 commit into release-it:main from teamoo:patch-1

Oct 5, 2023

Contributor

teamoo commented Oct 5, 2023

Given this code:
https://github.com/release-it/release-it/blob/38193c37f6e570907eb8c7df02a9a41714eba509/lib/plugin/github/GitHub.js#L375C1-L379C51

I think that the parameter to set has to be github.comments.submit instead of github.comments


          fix: name of param to enable comment functionality

9a4c82b

Given this code:
https://github.com/release-it/release-it/blob/38193c37f6e570907eb8c7df02a9a41714eba509/lib/plugin/github/GitHub.js#L375C1-L379C51

I think that the parameter to set has to be `github.comments.submit` instead of `github.comments`

webpro merged commit fdcf005 into release-it:main

Collaborator

webpro commented Oct 5, 2023

You couldn't be more right! Thanks 🙏

Collaborator

webpro commented Nov 11, 2023

🚀 This pull request is included in v17.0.0. See Release 17.0.0 for release notes.

Collaborator

webpro commented Nov 29, 2023

🚀 This pull request is included in v16.3.0. See Release 16.3.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment