Bug - Issue with github comment on resolved items

[juancarlosjr97]

v17.1.0 brings the functionality to add comments on PRs in CI environments.

However, it appears to be an issue with the feature as it now fails when trying to add a comment. See here.

The release does not fail as it happened before but execution fails.

[juancarlosjr97]

I have not had time to look into it, just noticed it one a release using the latest version.

[juancarlosjr97]

The issue is...

file:///home/runner/work/release-it-pre-releases/release-it-pre-releases/node_modules/ora/index.js:385
		throw new TypeError('Parameter `action` must be a Function or a Promise');
		      ^

TypeError: Parameter `action` must be a Function or a Promise

From here https://github.com/sindresorhus/ora/blob/main/index.js#L384-L385

[webpro]

If it's an issue with Ora then there might be something off with --ci or CI env var not set? Otherwise you can try to set github.comments.submit to false.

Of course there can be a bug in release-it, too.

[juancarlosjr97]

The action is running npx release-it --ci --git.tagExclude='*[-]*'.

[juancarlosjr97]

Just in case, I tried updating the release configuration to github comments to false. See here and the commit

[juancarlosjr97]

Well, it is correctly going to that scope as the --ci flag is set. Now, I am trying to understand why the this.commentOnResolvedItems() is identified as not a Promise.

[webpro]

🚀 This issue has been resolved in v17.1.1. See Release 17.1.1 for release notes.

[webpro]

Maybe fixed it, shot in the dark 🔫

[juancarlosjr97]

I got green pipeline across projects :)

Thank you!

[webpro]

Green is good! piew piew 🔫