Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-it not change package.json file #748

Closed
YevheniiHorokhov opened this issue Mar 19, 2021 · 5 comments
Closed

release-it not change package.json file #748

YevheniiHorokhov opened this issue Mar 19, 2021 · 5 comments

Comments

@YevheniiHorokhov
Copy link

YevheniiHorokhov commented Mar 19, 2021

Helllo!
I try change version via release-it and it work fine for several time but today not work changing package.json version.
i run command "release-it" and it not change package.json version, only tag previous commit and push, but must change package.json, create new commit, tag it and push.

my config file
git:
commitMessage: 'chore: release v${version}'
tagName: 'v${version}'
npm:
publish: false

log history

🚀 Let's release folfok.api (currently at 0.17.9)

Empty changelog

? Select increment (next version): patch (0.17.10)

Empty changeset

? Commit (chore: release v0.17.10)? Yes

On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
WARNING No changes to commit. The latest commit will be tagged.

@webpro
Copy link
Collaborator

webpro commented Mar 19, 2021

How does your config file look like exactly?

Also see https://github.com/release-it/release-it/blob/master/docs/npm.md#skip-publish

@YevheniiHorokhov
Copy link
Author

How does your config file look like exactly?

Also see https://github.com/release-it/release-it/blob/master/docs/npm.md#skip-publish

my config file
git:
commitMessage: 'chore: release v${version}'
tagName: 'v${version}'
npm:
publish: false

@webpro
Copy link
Collaborator

webpro commented Mar 19, 2021

That's not exactly the file, right? Can you create a code block and insert the JSON (or whatever).

Anyway, if it works for "several times", then I would think that somehow something has changed on your end. Are you running release-it from the project root directory, that has the package.json (which is not modified somehow by something else)?

You should also try a debug run, to see exactly what's going on:

DEBUG=release-it:* release-it [...]

@YevheniiHorokhov
Copy link
Author

@webpro thanks a lot, it worked now, need run from root directory as you say. Webstorm by default open last directory ('src') and i miss it. Really thanks.

@webpro webpro closed this as completed in 220fcda Mar 24, 2021
@webpro
Copy link
Collaborator

webpro commented Mar 24, 2021

Alright, great. I added a comment to the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants