github.proxy not worked?

[afeiship]

proxy

https://github.com/release-it/release-it/blob/master/lib/plugin/github/GitHub.js#L170

get client() {
    if (this._client) return this._client;
    const { proxy, timeout } = this.options;
    const host = this.options.host || this.getContext('repo.host');
    const isGitHub = host === 'github.com';
    const baseUrl = `https://${isGitHub ? 'api.github.com' : host}${isGitHub ? '' : '/api/v3'}`;
    const options = {
        baseUrl,
        auth: `token ${this.token}`,
        userAgent: `release-it/${pkg.version}`,
        log: this.config.isDebug ? console : null,
        request: {
            timeout
        }
    };

    if (proxy) {
        options.proxy = proxy;
        // so, maybe this should be worked?
        options.request.agent = new ProxyAgent(proxy);
    }

    const client = new Octokit(options);

    this._client = client;
    return client;
}

my case

not worked when i only use proxy

worked when i add options.request.agent = new Proxy(options.proxy)

[webpro]

Interesting. Could you please open a PR with this fix?

Maybe there has been an update in @octokit/rest or @octokit/request I've missed.

[afeiship]

@webpro thx, you have fixed the bug in new version. :)
I have a template script to fix in my project, waiting for new verison release!

// 1. Add proxy to `.release-it.json`
// 2. ./node_modules/release-it/lib/plugin/github/GitHub.js
// 3. const prompts = require('./prompts'); ---> const ProxyAgent = require('proxy-agent');
// 4. options.proxy = proxy; --->  options.request.agent = new ProxyAgent(proxy);
// 5. add proxy to package.json

[webpro]

Sorry @afeiship! I pushed to code to test it in the GitHub Action, but forgot to release-it! It's in v14.14.3

[afeiship]

@webpro thanks, I have installed(v14.14.3) it in my project, it worked!