Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict Node.js v10 support #892

Merged
merged 2 commits into from Apr 11, 2022
Merged

Strict Node.js v10 support #892

merged 2 commits into from Apr 11, 2022

Conversation

webpro
Copy link
Collaborator

@webpro webpro commented Apr 10, 2022

Adds engine-strict=true, a few dependency downgrades, and a resolution (for Yarn)

@webpro webpro mentioned this pull request Apr 10, 2022
Closed
@webpro webpro merged commit 43d74fe into master Apr 11, 2022
@webpro webpro deleted the chore/strict-node-v10-support branch April 11, 2022 15:05
@bmish
Copy link
Contributor

bmish commented Apr 11, 2022

Thanks! This finally enables me to upgrade now that the Node 10 CI check passes: ember-cli/eslint-plugin-ember#1463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@webpro @bmish