Fixes github.proxy not working (#863) #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a recent change in Octokits docs[1], in order for it to use a configured proxy you must pass another request.agent into the Octokit constructor. This change adds the `proxy-agent` lib as suggested by Octokits docs. Note that with this implmentation, the `http_proxy` or `https_proxy` environment variables alone will NOT work. Instead one must explicitly set the value in the `github.proxy` option passed to release-it. This is to stay inline with current behavior[2]. [1] octokit/octokit.js@2090c85 [2] https://github.com/release-it/release-it/blob/14.14.2/docs/github-releases.md#proxy
|
This PR is to address #863 |
dgcofer
commented
Apr 14, 2022
| releaseUrl, | ||
| 'https://custom.example.org/user/repo/releases/new?tag=2.0.2&title=The+Launch&body=It+happened&prerelease=false' | ||
| ); | ||
| t.is(github.options.proxy, 'http://proxy.example.org:8181'); |
There was a problem hiding this comment.
Wasn't really to sure on how to test for this scenario, Ava is not my forte 😉
I welcome any suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a recent change in Octokits docs[1], in order for it to use a
configured proxy you must pass another request.agent into the Octokit
constructor. This change adds the
proxy-agentlib as suggested byOctokits docs.
Note that with this implmentation, the
http_proxyorhttps_proxyenvironment variables alone will NOT work. Instead one must explicitly
set the value in the
github.proxyoption passed to release-it. This isto stay inline with current behavior[2].
[1] octokit/octokit.js@2090c85
[2] https://github.com/release-it/release-it/blob/14.14.2/docs/github-releases.md#proxy