feat: make exit 0 possible when commits required but missing #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Love this PR, that |
webpro
added a commit
that referenced
this pull request
Mar 1, 2023
* feat: make exit 0 possible when commits required but missing * fix: removed dummy code --------- Co-authored-by: Lars Kappert <lars@webpro.nl>
|
Apparently I missed a line when fixing conflicts here in the GitHub UI, merged anyway to fix locally and push into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a possibility to exit with 0 code (success) when
requireCommits: trueand no commits available.Why this is handy:
Alongside with this PR #982 it will make release-it a monorepo best friend.
Some times it is OK not to have commits related to a certain workspace. Exit with error may stop the pipeline execution, depending on CI configuration.
This particular feature is inspired by monorepo managed by turborepo where every workspace has a
"release": "release-it"npm script inpackage.json.When turbo release pipeline is executed failing releases are:
I my case, right now, a custom script, which checks if there commits that touch a specific workspace, prevents an execution of release-it (not to exit with non zero code).
Its kinda specific use case but I think it can be a great addition to release-it.