Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:update click and tomlkit #339

Merged

Conversation

lyz-code
Copy link
Contributor

@lyz-code lyz-code commented Jun 8, 2021

No description provided.

@danth danth merged commit 947ea3b into python-semantic-release:master Jun 8, 2021
@@ -43,7 +44,7 @@ def _read_long_description():
"requests>=2.25,<3",
"wheel",
"python-gitlab>=1.10,<3",
"tomlkit==0.7.0",
"tomlkit==0.7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this was pined to 0.7.0 as it seems it was causing a bug where the pyproject.toml was being wiped.

Should probably have left a comment or even better write a test reproducing the problem... 😞

danth added a commit that referenced this pull request Jun 8, 2021
@grawlinson
Copy link

Has this issue been reported upstream?

@browniebroke
Copy link
Contributor

So it turns out to be a problem only when the TOML file has out-of-order tables. The spec discourages them ("Defining tables out-of-order is discouraged."), but they are considered valid.

I tried to look at tomlkit, but it has several tests for them, and it seems to work fine on its own. However, when used with dotty-dict -like it's used in PSR- we see the problem from #336, so I'm not too sure to which upstream this should be reported: tomlkit or dotty-dict...

I've added a test case in #349, to make sure we get the right behaviour in PSR (at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants