Feature: add option to omit tagging #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use
python-semantic-releasein a monorepo, where I need to version individual libraries separately. This sadly gets blockedpython-semantic-release: Some libraries could have the same version and while versioning would like to create the same (an existing) tag.This PR solves this problem (the easy way for now) by adding an option to omit the tagging of commits. This obviously only works with the
version_source="commit"option.I'm relatively new to python, so any feedback on the implementation is highly appreciated :)
OT: it would be nice if
python-semantic-releasewould support custom version string formats, e.g. like lerna for js does - this would enable alpha, beta, canary releases as well as custom version tags for individual libs in monorepos.Should this be an interesting option, I would create a real issue for this and would throw in my dev hands to implement this :)