Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setting for enforcing ascii changlelog sections #502

Conversation

cowofevil
Copy link
Contributor

Resolves #498

Add the 'enforce_ascii_changelog_sections' setting flag for enforcing that changelog section headings will always be regular ASCII when using the Emoji parser.

Resolves python-semantic-release#498

Add the 'enforce_ascii_changelog_sections' setting flag for enforcing that
changelog section headings will always be regular ASCII when using the Emoji
parser.
Copy link
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Perhaps use_textual_changelog_sections would be a more fitting name? Mentioning ASCII specifically is an unnecessary level of detail.

Updating setting and associated documentation to with
'use_textual_changelog_sections' as it is easier to understand and less
specific concerning character set.
@cowofevil
Copy link
Contributor Author

@danth Agreed, I think use_textual_changelog_sections is more understandable.

@danth danth merged commit 988437d into python-semantic-release:master Sep 25, 2022
@cowofevil cowofevil deleted the feature/498-plaintext-changelog-emoji-parser branch May 18, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plain Text Changelog Section Description Setting for Emoji Parser
2 participants