fix: handle missing configuration #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, PSR will no longer error if it cannot find appropriate configuration in the default pyproject.toml file, or in the file specified by -c/ --config when that option is given. Instead it will use the default configuration values
bernardcooke53
commented
Jul 18, 2023
| @@ -21,7 +21,7 @@ classifiers = [ | |||
| readme = "README.rst" | |||
| authors = [{ name = "Rolf Erik Lekang", email = "me@rolflekang.com" }] | |||
| dependencies = [ | |||
| "click>=7,<9", | |||
| "click>=8,<9", | |||
There was a problem hiding this comment.
don't allow previous major versions of click
bernardcooke53
commented
Jul 18, 2023
| @@ -62,7 +62,7 @@ test = [ | |||
| "types-pytest-lazy-fixture>=0.6.3.3", | |||
| ] | |||
| dev = ["tox", "isort", "black"] | |||
| mypy = ["mypy", "types-requests", "types-click"] | |||
| mypy = ["mypy", "types-requests"] | |||
There was a problem hiding this comment.
types-click was actually breaking mypy for me locally - I suppose it's no longer updated with click v8 (hence pinning above)
bernardcooke53
commented
Jul 18, 2023
| @@ -124,7 +124,7 @@ commands = | |||
| [testenv:mypy] | |||
| deps = .[mypy] | |||
| commands = | |||
| mypy --ignore-missing-imports semantic_release | |||
| mypy semantic_release | |||
There was a problem hiding this comment.
no need for this flag any more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, PSR will no longer error if it cannot find appropriate configuration in the default
pyproject.toml file, or in the file specified by -c/ --config when that option is given. Instead it will use the default configuration values