Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't warn about vcs token if ignore_token_for_push is true. #670

Merged

Conversation

lukester1975
Copy link
Contributor

Hi

If not using GH_TOKEN (or whatever appropriate for the server type), the warning

WARNING  [semantic_release.cli.config] WARNING config.from_raw_config:  config.py:331
         the token for the remote VCS is configured as stored in the                 
         GH_TOKEN environment variable, but it is empty

is a bit noisy, IMHO.

[tool.semantic_release.remote]
token = ""

will quieten it. How about also checking ignore_token_for_push like this; saves having to have the config entry at all?

Thanks!

Copy link
Contributor

@bernardcooke53 bernardcooke53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems sound to me - thank you!

@bernardcooke53 bernardcooke53 merged commit f1a54a6 into python-semantic-release:master Aug 10, 2023
6 of 7 checks passed
@lukester1975 lukester1975 deleted the fix-token-warning branch August 11, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants