Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error when running build command on windows systems #732

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: Error when running build command on windows systems #732

merged 1 commit into from
Oct 10, 2023

Conversation

JCHacking
Copy link
Contributor

On Windows systems, if the shell you get is cmd instead of executing the command it opens a shell
This is because instead of telling it cmd /c COMMAND it is sent cmd -c COMMAND

@JCHacking
Copy link
Contributor Author

Can any maintainer check if this is ok or do I need some more action on the PR? This is the second one I've opened on GitHub and I don't know if it requires any further action on my part.

@bernardcooke53
Copy link
Contributor

Hey @JCHacking - thank you for the PR, nothing else needed from your side!

@bernardcooke53 bernardcooke53 merged commit 2553657 into python-semantic-release:master Oct 10, 2023
6 of 8 checks passed
@JCHacking
Copy link
Contributor Author

@bernardcooke53 When will a new version with this fix be released?

@bernardcooke53
Copy link
Contributor

@JCHacking this should be part of v8.1.2 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants