docs(migration): fix comments about publish command #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardcooke53
approved these changes
Dec 7, 2023
bernardcooke53
merged commit 90380d7
into
python-semantic-release:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update the migration documentation for clarity of what
publishcommand does now as opposed to before.Rationale
This section was a great write up to explain how I can go about migrating from
v7tov8, however I was very confused about the order of operations when I reviewed the version and publish code. I corrected the steps and alignment to each command in this PR after reviewing the code segments. This adjustment lines up with howversioncan/will run a new build and the second statement about removing the wrappedtwinefunctionality.