-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hvcs): allow insecure http connections if configured #886
Merged
codejedi365
merged 20 commits into
python-semantic-release:master
from
codejedi365:fix/support-4-insecure-connections
Apr 14, 2024
Merged
fix(hvcs): allow insecure http connections if configured #886
codejedi365
merged 20 commits into
python-semantic-release:master
from
codejedi365:fix/support-4-insecure-connections
Apr 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
force-pushed
the
fix/support-4-insecure-connections
branch
3 times, most recently
from
April 8, 2024 05:05
a20a922
to
3977154
Compare
codejedi365
force-pushed
the
fix/support-4-insecure-connections
branch
from
April 10, 2024 02:11
3977154
to
b27d481
Compare
codejedi365
force-pushed
the
fix/support-4-insecure-connections
branch
from
April 13, 2024 01:01
b27d481
to
660d2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the hard coded
https://
throughout the code and allow a flag to toggle insecure modeRationale
Although insecure connections are highly not recommended, it is not the job of PSR to enforce this standard. Internal networks do not always have the luxury of public CAs to provide trusted HTTPS and sometimes HTTP must be used. This is the risk of the network owner. This implementation follows the concept of
Podman
to add to the configuration theinsecure
flag to a defined url. The default is to prevent HTTP if detected and throw a warning as it could easily be a typo but ultimately allow the user to validate that, "yes, I know it is insecure but do it anyway". We previously would not support this at all. Note that this was less of an issue until the last release when url schemes became more regulated with the url parsing.