Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hvcs): allow insecure http connections if configured #886

Conversation

codejedi365
Copy link
Contributor

@codejedi365 codejedi365 commented Apr 7, 2024

Purpose

Remove the hard coded https:// throughout the code and allow a flag to toggle insecure mode

Rationale

Although insecure connections are highly not recommended, it is not the job of PSR to enforce this standard. Internal networks do not always have the luxury of public CAs to provide trusted HTTPS and sometimes HTTP must be used. This is the risk of the network owner. This implementation follows the concept of Podman to add to the configuration the insecure flag to a defined url. The default is to prevent HTTP if detected and throw a warning as it could easily be a typo but ultimately allow the user to validate that, "yes, I know it is insecure but do it anyway". We previously would not support this at all. Note that this was less of an issue until the last release when url schemes became more regulated with the url parsing.

@codejedi365 codejedi365 added the blocked Requires something else before merge or fix label Apr 7, 2024
@codejedi365 codejedi365 self-assigned this Apr 7, 2024
@codejedi365 codejedi365 added the needs-docs Documentation needs to be updated label Apr 7, 2024
@codejedi365 codejedi365 force-pushed the fix/support-4-insecure-connections branch 3 times, most recently from a20a922 to 3977154 Compare April 8, 2024 05:05
@codejedi365 codejedi365 marked this pull request as ready for review April 8, 2024 05:08
@codejedi365 codejedi365 force-pushed the fix/support-4-insecure-connections branch from 3977154 to b27d481 Compare April 10, 2024 02:11
@codejedi365 codejedi365 force-pushed the fix/support-4-insecure-connections branch from b27d481 to 660d2c2 Compare April 13, 2024 01:01
@codejedi365 codejedi365 removed the blocked Requires something else before merge or fix label Apr 13, 2024
@codejedi365 codejedi365 removed the needs-docs Documentation needs to be updated label Apr 14, 2024
@codejedi365 codejedi365 merged commit db13438 into python-semantic-release:master Apr 14, 2024
7 checks passed
@codejedi365 codejedi365 deleted the fix/support-4-insecure-connections branch April 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant